Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user agent to Firefox ESR 128 #11268

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update user agent to Firefox ESR 128 #11268

merged 1 commit into from
Nov 18, 2024

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jul 13, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Updates the user agent used by the downloader to retrieve files to a current version

Related PR

See TeamNewPipe/NewPipeExtractor#1192

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added the privacy & data protection Issues regarding either NewPipe, Team NewPipe services or external services NewPipe uses label Jul 13, 2024
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 13, 2024
wb9688
wb9688 reviewed Jul 13, 2024
View reviewed changes
Copy link
Contributor

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why still Windows 10? And did you take this string from an actual instance of Firefox 128 on Windows 10 or just changed the number?

@opusforlife2
Copy link
Collaborator

Also, we completely skipped 2 ESR versions. Can there be a Github Action to update this automatically, or at least remind us?

@wb9688
Copy link
Contributor

wb9688 commented Jul 13, 2024

Also, we completely skipped 2 ESR versions. Can there be a Github Action to update this automatically, or at least remind us?

What about adding it to our release process documentation?

@TobiGr
Copy link
Contributor Author

TobiGr commented Jul 14, 2024 •
edited
Loading

Why still Windows 10? And did you take this string from an actual instance of Firefox 128 on Windows 10 or just changed the number?

I have seen both user agents with and without the architecture info. We could also change to

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0

In that case I'd update TeamNewPipe/NewPipeExtractor#1192 first to check whether this causes any problems.

Also, we completely skipped 2 ESR versions. Can there be a Github Action to update this automatically, or at least remind us?

What about adding it to our release process documentation?

I also thought about creating a workflow for that. But that should happen in the extractor because user agent changes should be checked there. I don't think that updating the UA should be part of the release process because a faulty UA could brake stuff.

@ale5000-git
Copy link

ale5000-git commented Jul 18, 2024 •
edited
Loading

Wht not using the User-Agent of ESR build of Firefox for Linux?
They change more rarely and they are supported for long time so they can't be blocked.
Example: Mozilla/5.0 (Linux x86_64; rv:115.0) Gecko/20100101 Firefox/115.0

@TobiGr
Copy link
Contributor Author

TobiGr commented Jul 22, 2024 •
edited
Loading

We are always using the ESR version. I should have specified this. The current ESR version is 128

@TobiGr TobiGr changed the title Update user agent to Firefox 128 Update user agent to Firefox ESR 128 Jul 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TeamNewPipe TeamNewPipe deleted a comment from sonarqubecloud bot Nov 3, 2024
@AudricV AudricV mentioned this pull request Nov 17, 2024
Closed
7 tasks
@Stypox Stypox merged commit 10e7a5c into dev Nov 18, 2024
6 checks passed
@TobiGr TobiGr deleted the user-agent branch November 18, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wb9688 wb9688 wb9688 left review comments

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
privacy & data protection Issues regarding either NewPipe, Team NewPipe services or external services NewPipe uses size/small PRs with less than 50 changed lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TobiGr @opusforlife2 @wb9688 @ale5000-git @Stypox